Feature #2362 message_type_group_map #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type groups into the PointStatConfInfo::process_geog() function. Only check for these if topo_mask.flag and/or land_mask.flag are true.
…y when SURFACE/LANDSF/WATERSF must be defined.
jprestop
approved these changes
Dec 2, 2022
|
Thanks for the review @jprestop. @robdarvell I'm going to proceed with merging this PR based on Julie's review. My intention by adding you as a reviewer was to make you aware of this fix. So you'll only need to define SURFACE, LANDSF, and WATERSF in the future if you actually turn on the land_mask and topo_mask options. Since you know that now, I'd say mission accomplished! Thanks! |
Closed
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Used the data in
make testto test out this logic. When message_type_group_map in data/config/PointStatConfig is empty,make testnow runs without error. Previously it errored out about SURFACE/LANDSF/WATERSF being missing. I ran this iteratively to trigger each of these errors separately. And then I reran iteratively to confirm that these errors are no longer present.Also, set
topo_mask.flag = trueandland_mask.flag = trueand confirmed that that triggers the warning messages, as expected.Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
@jprestop, review minor code change and confirm that all GHA runs pass without producing any diffs.
@robdarvell, review the updated land_mask and topo_mask documentation to confirm that it clearly defines the message_type_group_map handling.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [No]
None needed.
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Mon 12/5/22].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes